apio/Luna
1
1
Fork 0
Code Issues Pull Requests Actions Projects Releases 8 Wiki Activity

kernel: Disallow write-related flags when opening a directory, not only when the directory flag is set
All checks were successful
continuous-integration/drone/push Build is passing
Details

Browse Source 
Also return EISDIR instead of EINVAL as that is what Dr. POSIX mandates.
This commit is contained in:
apio 2023-05-11 21:29:49 +02:00
parent 1035b91a3d
commit 64d0f30bd9
Signed by: apio
GPG Key ID: B8A7D06E42258954
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
kernel/src/sys/open.cpp
View File

@ -23,11 +23,6 @@ Result<u64> sys_openat(Registers*, SyscallArgs args)
// Caller did not pass either O_RDONLY, O_WRONLY or O_RDWR
if ((flags & O_RDWR) == 0) { return err(EINVAL); }
if (flags & O_DIRECTORY)
{
if ((flags & O_WRONLY) || (flags & O_CREAT)) return err(EINVAL);
}
if (flags & O_TMPFILE)
{
if (!(flags & O_WRONLY)) return err(EINVAL);
@ -66,6 +61,11 @@ Result<u64> sys_openat(Registers*, SyscallArgs args)
if (inode->type() != VFS::InodeType::Directory && (flags & O_DIRECTORY)) return err(ENOTDIR);
if (inode->type() == VFS::InodeType::Directory)
{
if ((flags & O_WRONLY) || (flags & O_CREAT)) return err(EISDIR);
}
if ((flags & O_WRONLY) && (flags & O_TRUNC)) inode->truncate(0);
int fd = TRY(current->allocate_fd(0));