apio/Luna
1
1
Fork 0
Code Issues Pull Requests Actions Projects Releases 8 Wiki Activity

kernel+launch: Always send SIGCHLD when a child exits
All checks were successful
Build and test / build (push) Successful in 1m44s
Details

Browse Source 
POSIX says so. I thought it was only when the parent wasn't actively waiting, to signal it, but it turns out it's always sent.
This commit is contained in:
apio 2024-12-04 22:44:16 +01:00
parent 0ca6c5f814
commit 7761a8a41f
Signed by: apio
GPG Key ID: B8A7D06E42258954
2 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gui/launch.cpp
View File

@ -48,7 +48,7 @@ void handle_ipc_message(os::IPC::ClientConnection& client, u8 id, void*)
void sigchld_handler(int) void sigchld_handler(int)
{ {
os::Process::wait(os::Process::ANY_CHILD, nullptr); os::Process::wait(os::Process::ANY_CHILD, nullptr, WNOHANG);
} }
Result<int> luna_main(int argc, char** argv) Result<int> luna_main(int argc, char** argv)

7
kernel/src/thread/Thread.cpp
View File

@ -147,11 +147,8 @@ Result<SharedPtr<VFS::Inode>> Thread::resolve_atfile(int dirfd, const String& pa
parent->wake_up(); parent->wake_up();
} }
} }
else while (parent->pending_signals.get(SIGCHLD - 1)) kernel_yield();
{ parent->send_signal(SIGCHLD);
while (parent->pending_signals.get(SIGCHLD - 1)) kernel_yield();
parent->send_signal(SIGCHLD);
}
} }
state = ThreadState::Exited; state = ThreadState::Exited;