apio/Luna
1
1
Fork 0
Code Issues Pull Requests Actions Projects Releases 8 Wiki Activity

su: Use user names and read from the password file instead of using raw user IDs

Browse Source
This commit is contained in:
apio 2023-04-08 16:31:33 +02:00
parent 7667f49d62
commit 8b45766aaa
Signed by: apio
GPG Key ID: B8A7D06E42258954
1 changed files with 15 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
apps/su.cpp
View File

@ -1,11 +1,12 @@
#include <os/ArgumentParser.h> #include <os/ArgumentParser.h>
#include <pwd.h>
#include <stdio.h> #include <stdio.h>
#include <stdlib.h> #include <stdlib.h>
#include <unistd.h> #include <unistd.h>
int main(int argc, char** argv) int main(int argc, char** argv)
{ {
StringView id; StringView name;
if (geteuid() != 0) if (geteuid() != 0)
{ {
@ -14,19 +15,24 @@ int main(int argc, char** argv)
} }
os::ArgumentParser parser; os::ArgumentParser parser;
parser.add_positional_argument(id, "id"_sv, true); parser.add_positional_argument(name, "name"_sv, true);
parser.parse(argc, argv); parser.parse(argc, argv);
int uid = atoi(id.chars()); struct passwd* entry = getpwnam(name.chars());
if (!entry)
if (uid == 0)
{ {
fprintf(stderr, "Already root!\n"); fprintf(stderr, "su: user %s not found!\n", name.chars());
return 1; return 1;
} }
setgid(uid); if (getuid() != geteuid())
setuid(uid); {
fprintf(stderr, "FIXME: you have to enter %s's password first!\n", name.chars());
return 1;
}
execl("/bin/sh", "sh", NULL); setgid(entry->pw_gid);
setuid(entry->pw_uid);
execl(entry->pw_shell, entry->pw_shell, NULL);
} }