apio/Luna
1
1
Fork 0
Code Issues Pull Requests Actions Projects Releases 8 Wiki Activity

Do not use __builtin_alloca in puts (could overflow the stack for large strings)

Browse Source
This commit is contained in:
apio 2022-10-03 19:05:04 +02:00
parent 34aa953dbc
commit 9420484c9b
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
libs/libc/src/stdio.cpp
View File

@ -49,10 +49,8 @@ extern "C"
} }
int puts(const char* s) int puts(const char* s)
{ {
size_t len = strlen(s); long nwritten = syscall(SYS_write, s, strlen(s));
char* output = (char*)__builtin_alloca(len + 1); nwritten += syscall(SYS_write, "\n", 1);
memcpy(output, s, len); return nwritten;
output[len] = '\n';
return syscall(SYS_write, output, len + 1);
} }
} }