apio/Luna
1
1
Fork 0
Code Issues Pull Requests Actions Projects Releases 8 Wiki Activity

Check for overflow/underflow in parse_signed_integer
All checks were successful
continuous-integration/drone/push Build is passing
Details

Browse Source
This commit is contained in:
apio 2022-12-17 14:42:56 +01:00
parent 59c9d8f119
commit 97cb57d521
Signed by: apio
GPG Key ID: B8A7D06E42258954
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
luna/src/NumberParsing.cpp
View File

@ -1,3 +1,4 @@
#include <limits.h>
#include <luna/CType.h> #include <luna/CType.h>
#include <luna/NumberParsing.h> #include <luna/NumberParsing.h>
@ -47,6 +48,9 @@ usize parse_unsigned_integer(const char* str, const char** endptr, int base)
return val; return val;
} }
#define SSIZE_MAX LONG_MAX
#define SSIZE_MIN (-SSIZE_MAX - (isize)1)
isize parse_signed_integer(const char* str, const char** endptr, int base) isize parse_signed_integer(const char* str, const char** endptr, int base)
{ {
bool negative = false; bool negative = false;
@ -59,9 +63,9 @@ isize parse_signed_integer(const char* str, const char** endptr, int base)
str++; str++;
} }
usize rc = parse_unsigned_integer( usize rc = parse_unsigned_integer(str, endptr, base);
str, endptr,
base); // FIXME: Check for overflow (the unsigned usize value might not fit into a signed isize) if (rc > SSIZE_MAX) { return negative ? SSIZE_MIN : SSIZE_MAX; }
return negative ? -(isize)rc : (isize)rc; return negative ? -(isize)rc : (isize)rc;
} }