mkdir: Use os::FileSystem and add -p flag

apps/mkdir.cpp

@@ -1,23 +1,49 @@
+#include <luna/NumberParsing.h>
+#include <luna/PathParser.h>
 #include <os/ArgumentParser.h>
-#include <stdio.h>
+#include <os/FileSystem.h>
-#include <stdlib.h>
-#include <sys/stat.h>
 
-int main(int argc, char** argv)
+Result<void> mkdir_recursively(StringView path, mode_t mode)
+{
+begin:
+    auto rc = os::FileSystem::create_directory(path, mode);
+    if (!rc.has_error()) return {};
+
+    if (rc.error() == EEXIST) return {};
+    if (rc.error() == ENOENT)
+    {
+        PathParser parser = TRY(PathParser::create(path.chars()));
+        auto parent = TRY(parser.dirname());
+
+        TRY(mkdir_recursively(parent.view(), mode));
+
+        goto begin;
+    }
+
+    return rc.release_error();
+}
+
+Result<int> luna_main(int argc, char** argv)
 {
     StringView path;
     StringView mode_string;
+    bool recursive;
 
     os::ArgumentParser parser;
     parser.add_positional_argument(path, "path"_sv, true);
     parser.add_positional_argument(mode_string, "mode"_sv, "755"_sv);
+    parser.add_switch_argument(recursive, 'p', "parents"_sv);
     parser.parse(argc, argv);
 
-    mode_t mode = (mode_t)strtoul(mode_string.chars(), NULL, 8);
+    mode_t mode = (mode_t)parse_unsigned_integer(mode_string.chars(), nullptr, 8);
 
-    if (mkdir(path.chars(), mode) < 0)
+    if (recursive)
     {
-        perror("mkdir");
+        TRY(mkdir_recursively(path, mode));
-        return 1;
+        return 0;
     }
+
+    TRY(os::FileSystem::create_directory(path, mode));
+
+    return 0;
 }

apps/rm.cpp

@@ -1,5 +1,5 @@
 #include <os/ArgumentParser.h>
-#include <stdio.h>
+#include <os/FileSystem.h>
 
 Result<int> luna_main(int argc, char** argv)
 {
@@ -9,11 +9,7 @@ Result<int> luna_main(int argc, char** argv)
     parser.add_positional_argument(path, "path"_sv, true);
     parser.parse(argc, argv);
 
-    if (remove(path.chars()) < 0)
+    TRY(os::FileSystem::remove(path));
-    {
-        perror("rm");
-        return 1;
-    }
 
     return 0;
 }

apps/sh.cpp

@@ -1,5 +1,8 @@
+#include <luna/String.h>
 #include <luna/Vector.h>
 #include <os/ArgumentParser.h>
+#include <os/File.h>
+#include <os/FileSystem.h>
 
 #include <errno.h>
 #include <stddef.h>
@@ -9,9 +12,11 @@
 #include <sys/wait.h>
 #include <unistd.h>
 
-static Result<Vector<char*>> split_command_into_argv(const char* cmd)
+using os::File;
+
+static Result<Vector<char*>> split_command_into_argv(StringView cmd)
 {
-    char* str = strdup(cmd);
+    char* str = strdup(cmd.chars());
 
     Vector<char*> result;
 
@@ -31,7 +36,7 @@ static Result<Vector<char*>> split_command_into_argv(const char* cmd)
     return result;
 }
 
-[[noreturn]] static void execute_command(const char* command)
+[[noreturn]] static void execute_command(StringView command)
 {
     Vector<char*> argv;
     bool ok = split_command_into_argv(command).try_move_value_or_error(argv, errno);
@@ -49,48 +54,55 @@ static Result<Vector<char*>> split_command_into_argv(const char* cmd)
 
 Result<int> luna_main(int argc, char** argv)
 {
-    StringView file;
+    StringView path;
     StringView command;
+    bool interactive { false };
 
-    FILE* f;
+    SharedPtr<File> input_file;
 
     os::ArgumentParser parser;
-    parser.add_positional_argument(file, "file"_sv, "-"_sv);
+    parser.add_positional_argument(path, "path"_sv, "-"_sv);
     parser.add_value_argument(command, 'c', "command"_sv, true);
     parser.parse(argc, argv);
 
-    if (!command.is_empty()) { execute_command(command.chars()); }
+    if (!command.is_empty()) execute_command(command);
 
-    if (file == "-") f = stdin;
+    if (path == "-")
+    {
+        input_file = File::standard_input();
+        interactive = true;
+    }
     else
-    {
+        input_file = TRY(File::open(path, File::ReadOnly));
-        f = fopen(file.chars(), "r");
-        if (!f)
-        {
-            perror("fopen");
-            return 1;
-        }
-    }
 
     while (1)
     {
-        if (file == "-")
+        if (interactive)
         {
-            char* cwd = getcwd(NULL, 0);
+            auto cwd = TRY(os::FileSystem::working_directory());
-            if (!cwd)
+            printf("sh %s%c ", cwd.chars(), getuid() == 0 ? '#' : '$');
-            {
-                perror("getcwd");
-                return 1;
-            }
-            printf("sh %s%c ", cwd, getuid() == 0 ? '#' : '$');
-            free(cwd);
         }
 
-        char cmd[4096];
+        auto cmd = TRY(input_file->read_line());
-        char* rc = fgets(cmd, sizeof(cmd), f);
+        if (cmd.is_empty()) break;
-        if (!rc) return 0;
 
-        if (strspn(cmd, " \n") == strlen(cmd)) continue;
+        if (strspn(cmd.chars(), " \n") == cmd.length()) continue;
+
+        if (!strncmp(cmd.chars(), "cd", 2))
+        {
+            auto args = TRY(split_command_into_argv(cmd.view()));
+            check("cd"_sv == args[0]);
+
+            if (args.size() == 2)
+            {
+                auto home = TRY(os::FileSystem::home_directory());
+                if (chdir(home.chars()) < 0) perror("cd");
+                continue;
+            }
+
+            if (chdir(args[1]) < 0) perror("cd");
+            continue;
+        }
 
         pid_t child = fork();
         if (child < 0)
@@ -99,7 +111,7 @@ Result<int> luna_main(int argc, char** argv)
             return 1;
         }
 
-        if (child == 0) { execute_command(cmd); }
+        if (child == 0) { execute_command(cmd.view()); }
 
         if (waitpid(child, NULL, 0) < 0)
         {
@@ -107,4 +119,6 @@ Result<int> luna_main(int argc, char** argv)
             return 1;
         }
     }
+
+    return 0;
 }

kernel/src/sys/id.cpp

@@ -116,7 +116,7 @@ Result<u64> sys_chown(Registers*, SyscallArgs args)
 
     Credentials& auth = Scheduler::current()->auth;
 
-    auto inode = TRY(VFS::resolve_path(path.chars(), auth));
+    auto inode = TRY(VFS::resolve_path(path.chars(), auth, Scheduler::current()->current_directory));
 
     if (auth.euid != 0) return err(EPERM);
 

libos/CMakeLists.txt

@@ -6,6 +6,7 @@ set(SOURCES
     ${HEADERS}
     src/ArgumentParser.cpp
     src/File.cpp
+    src/FileSystem.cpp
     src/Main.cpp
 )
 

libos/include/os/FileSystem.h

@@ -0,0 +1,21 @@
+#pragma once
+#include <luna/Result.h>
+#include <luna/StringView.h>
+#include <sys/types.h>
+
+namespace os
+{
+    namespace FileSystem
+    {
+        bool exists(StringView path);
+
+        bool is_directory(StringView path);
+
+        Result<void> create_directory(StringView path, mode_t mode);
+
+        Result<void> remove(StringView path);
+
+        Result<String> working_directory();
+        Result<String> home_directory();
+    }
+}

libos/src/FileSystem.cpp

@@ -0,0 +1,69 @@
+#include <luna/Ignore.h>
+#include <luna/String.h>
+#include <os/FileSystem.h>
+
+#include <errno.h>
+#include <pwd.h>
+#include <stdlib.h>
+#include <sys/stat.h>
+#include <sys/syscall.h>
+#include <unistd.h>
+
+namespace os::FileSystem
+{
+    bool exists(StringView path)
+    {
+        struct stat st;
+
+        if (stat(path.chars(), &st) < 0) return false;
+
+        return true;
+    }
+
+    bool is_directory(StringView path)
+    {
+        struct stat st;
+
+        if (stat(path.chars(), &st) < 0) return false;
+
+        return S_ISDIR(st.st_mode);
+    }
+
+    Result<void> create_directory(StringView path, mode_t mode)
+    {
+        long rc = syscall(SYS_mkdir, path.chars(), mode);
+        int _ignore = TRY(Result<int>::from_syscall(rc));
+
+        ignore(_ignore);
+
+        return {};
+    }
+
+    Result<void> remove(StringView path)
+    {
+        long rc = syscall(SYS_unlink, path.chars(), 0);
+        int _ignore = TRY(Result<int>::from_syscall(rc));
+
+        ignore(_ignore);
+
+        return {};
+    }
+
+    Result<String> working_directory()
+    {
+        char* ptr = getcwd(NULL, 0);
+        if (!ptr) return err(errno);
+        return String { ptr };
+    }
+
+    Result<String> home_directory()
+    {
+        char* home = getenv("HOME");
+        if (home) return String::from_cstring(home);
+
+        struct passwd* pw = getpwuid(getuid());
+        if (!pw) return err(ENOENT);
+
+        return String::from_cstring(pw->pw_dir);
+    }
+}