Start working on a VFS implementation #22

Closed

apio wants to merge 44 commits from oop-vfs into main

pull from: oop-vfs

merge into: apio:main

apio:main

apio:stable

apio:new-layout

Conversation 6 Commits 44 Files Changed 75 +853 -235

apio commented 2023-02-03 21:22:16 +00:00

Owner

Copy Link

One of the flaws of the old version of Luna was its VFS system. Let's see if we can get it right this time.

Draft because well, this PR is completely unfinished.

One of the flaws of the old version of Luna was its VFS system. Let's see if we can get it right this time. Draft because well, this PR is completely unfinished.

apio added 2 commits 2023-02-03 21:22:16 +00:00

SharedPtr: Delete ptr on failure in all adopt_shared* functions 51024f879d

kernel: Start working on a VFS implementation using OOP and SharedPtr cb4246b98d

apio added the

enhancement

label 2023-02-03 21:22:54 +00:00

apio self-assigned this 2023-02-03 21:23:01 +00:00

apio self-assigned this 2023-02-03 21:23:12 +00:00

apio removed their assignment 2023-02-03 21:23:30 +00:00

apio self-assigned this 2023-02-03 21:23:30 +00:00

apio added 1 commit 2023-02-14 19:00:05 +00:00

SharedPtr: Implement make_shared using adopt_shared 79078ff21e

apio commented 2023-02-14 19:01:40 +00:00

Author

Owner

Copy Link

I'm still working on this, just nothing useful to commit as it seems like the heap implementation is broken as soon as too many allocations are happening.

I'm still working on this, just nothing useful to commit as it seems like the heap implementation is broken as soon as too many allocations are happening.

apio added 3 commits 2023-02-14 19:07:37 +00:00

Option: Use __builtin_launder to ensure that the compiler doesn't label this as UB 6eff41e7af

kernel, luna: Move Spinlock.h to luna 4e88a7482c

luna: Use spinlocks in the heap implementation 38bd3d3eef

apio added 1 commit 2023-02-14 19:10:11 +00:00

luna: Skip UBSAN.cpp in CMakeLists as that's not implemented yet 08d5d727ee

apio added 1 commit 2023-02-14 19:17:35 +00:00

Heap: Avoid accessing a block after it's potentially deleted 4697a16206

apio added 1 commit 2023-02-17 21:47:48 +00:00

Heap: Fix GPF caused when making many small allocations ... 37bbc04719

Apparently space was too tight to split(), but we did it anyways, corrupting the next block.
This patch fixes this behavior.

apio commented 2023-02-17 21:48:26 +00:00

Author

Owner

Copy Link

I feel so dumb right now. Anyways, let's move on!

I feel so dumb right now. Anyways, let's move on!

apio added 1 commit 2023-02-17 23:18:55 +00:00

kernel: Switch to a stack we control for the main task as soon as we leave early boot ... d842443869

This is probably pointless as the main task only exists up until the point where the Scheduler starts running, but some init code was running into a stack overflow due to the fact that we only had one bootloader-provided page of stack.

This should probably be changed afterwards.

apio added 1 commit 2023-02-25 15:22:24 +00:00

Option, Result: Make try_move_value() non-const since it modifies the Option ae22321648

apio added 1 commit 2023-02-25 15:27:40 +00:00

OwnedPtr, SharedPtr: Add operator bool e9e1bef89c

apio referenced this issue from a commit 2023-02-25 16:09:13 +00:00

kernel, luna: Port non-VFS changes over from pull request #22

apio added 7 commits 2023-02-25 16:45:49 +00:00

libc: Make dbgln() also print a newline in userspace ... 96a213ec5c

Previously, dbgln() only printed a newline in kernel-space.

luna: Add UB sanitizer, for both kernel-space and userspace d82b3f809b

kernel: Enable UBSAN when building in debug mode 5f6a659fa1

luna: Introduce fail(...), a replacement for expect(false, ...) dc795ff491

kernel: Add a guard page to the bootstrap stack so that we can catch more stack overflows 32ada00b72

SharedPtr: Delete ptr on failure in all adopt_shared* functions 620810d720

SharedPtr: Implement make_shared using adopt_shared 6fc02e042a

apio referenced this issue from a commit 2023-02-25 16:48:43 +00:00

kernel, luna: Port non-VFS changes over from pull request #22

apio added 1 commit 2023-02-25 16:48:44 +00:00

kernel, luna: Port non-VFS changes over from pull request #22 ... 045efc7046

OwnedPtr, SharedPtr: Add operator bool
Option, Result: Make try_move_value() non-const since it modifies the Option
kernel: Switch to a stack we control for the main task as soon as we leave early boot
Heap: Fix GPF caused when making many small allocations
Heap: Avoid accessing a block after it's potentially deleted
luna: Skip UBSAN.cpp in CMakeLists as that's not implemented yet
luna: Use spinlocks in the heap implementation
kernel, luna: Move Spinlock.h to luna
Option: Use __builtin_launder to ensure that the compiler doesn't label this as UB
SharedPtr: Implement make_shared using adopt_shared
SharedPtr: Delete ptr on failure in all adopt_shared* functions

apio commented 2023-02-25 16:49:26 +00:00

Author

Owner

Copy Link

Rebased on main, hopefully UBSAN helps.

Rebased on main, hopefully UBSAN helps.

apio added 5 commits 2023-02-25 17:11:48 +00:00

kernel: Add a subclass of VFS::Inode to make it easier to implement file inodes 5edd316198

kernel: Make a factory function for filesystem creation of inodes, and add inode numbers ... ddc4692671

Now every filesystem must provide fs->create_file_inode() for new inodes :)

kernel: Rename FileSystem::root() to root_inode() and add a shortcut for the root filesystem's root inode 6daad7787a

tmpfs: Make m_next_inode_number atomic 05b627d037

tmpfs: rename tmpfs::Inode to tmpfs::FileInode b71d899b52

apio added 1 commit 2023-02-25 17:19:06 +00:00

Update README.md with realism 0635f1c243

apio commented 2023-02-25 17:19:30 +00:00

Author

Owner

Copy Link

Oops, that commit was supposed to be on main.

Oops, that commit was supposed to be on main.

apio added 3 commits 2023-02-25 18:34:14 +00:00

tmpfs: add DirInode skeleton cca4743a51

tmpfs: make the root inode a DirInode instead of a FileInode 9248a5b3cc

kernel: Implement creating file inodes in tmpfs directories 5b43345b7d

apio added 9 commits 2023-02-27 12:31:42 +00:00

x86_64/MMU: Map all physical memory into the higher half instead of using recursive mapping ... 78cea0a47e

This still has a few problems. Notably, we are not using huge pages for this mapping, which would be a lot more efficient.
Right now, used memory is 8.1 MiB at boot for a 256MiB system.
But after improving it, this system will be much better than recursive mapping.
fork() will be MUCH easier to implement, for example.

x86_64/MMU: Copy from the mapped kernel directory instead of the physical version 9da5204079

x86_64: Allow mapping huge pages, but don't do it yet efdd64736f

x86_64/MMU: Map the physical address space using huge pages ff01f49b41

MemoryManager: Reuse the existing mapping of physical memory that MMU has 9af6a3f30f

x86_64/MMU: Do not allocate level 1 page tables for huge page entries ... 2038ee1929

This would leak memory, since we would never end up using them.

x86_64: Remove recursive mapping related things from MMU.h a0252e42a4

MemoryManager: Initialize KernelVM at the end of init() ... 3654cc5bee

KernelVM is not needed for MMU's init process anymore.

InitRD: Use MMU::translate_physical_address instead of allocating VM ... 7f1884213a

This one is a perfect candidate, since we're just mapping a fixed continuous range of physical memory to virtual memory.

apio commented 2023-02-27 12:31:57 +00:00

Author

Owner

Copy Link

Rebased on main.

Rebased on main.

apio added 3 commits 2023-02-27 14:04:37 +00:00

Vector: Fix try_append (hopefully) ... ec146caeea

Still doesn't work with OwnedStringViews inside of structs.

luna: Add strlcpy() 19b72fe779

TmpFS: Use a fixed char array in DirInode's Entry instead of OwnedStringView 55b430a4fd

apio added 2 commits 2023-02-27 14:14:15 +00:00

luna: Add StaticString, an OOP char[] 76f9bd8112

TmpFS: Use StaticString<128> instead of char[128] 32dc5473a5

apio added 1 commit 2023-02-27 14:19:29 +00:00

luna -> libluna eebbbf0b16

apio referenced this issue from a commit 2023-02-27 14:22:47 +00:00

kernel, luna: Port non-VFS changes over from pull request #22

apio commented 2023-02-27 14:23:36 +00:00

Author

Owner

Copy Link

Merged manually, I'll continue work on main since this seems stable enough.

Merged manually, I'll continue work on main since this seems stable enough.

apio closed this pull request 2023-02-27 14:24:12 +00:00

apio reopened this pull request 2023-04-04 21:06:04 +00:00

apio changed title from WIP: Start working on a VFS implementation to Start working on a VFS implementation 2023-04-04 21:06:50 +00:00

apio closed this pull request 2023-04-04 21:09:09 +00:00

Some checks failed

Hide all checks

continuous-integration/drone/pr Build is failing

Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

wontfix

This won't be fixed

No Label

bug

duplicate

enhancement

help wanted

invalid

question

wontfix

Milestone

Clear milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

No Assignees

apio

1 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: apio/Luna#22

No description provided.