asleepymoon/Luna
1
1
Fork 0
Code Issues Pull Requests Actions Projects Releases 8 Wiki Activity

kernel: Interrupts are disabled while in system calls #32

New Issue
Closed
opened 2023-07-20 18:35:21 +00:00 by asleepymoon · 1 comment
asleepymoon commented 2023-07-20 18:35:21 +00:00
Owner
Copy Link

In x86_64's IDT.cpp, IDT_TA_TrapGate and IDT_TA_InterruptGate are used wrongly. Interrupt gates are called with interrupts disabled, trap gates are not. Thus, syscalls should have a new IDT_TA_UserCallableTrapGate value. IRQs should probably be configurable. Exceptions should stay this way (interrupts enabled on entry, as per the OSDev wiki.

In x86_64's [IDT.cpp](kernel/src/arch/x86_64/init/IDT.cpp), IDT_TA_TrapGate and IDT_TA_InterruptGate are used wrongly. Interrupt gates are called with interrupts disabled, trap gates are not. Thus, syscalls should have a new IDT_TA_UserCallableTrapGate value. IRQs should probably be configurable. Exceptions should stay this way (interrupts enabled on entry, as per the [OSDev wiki](https://wiki.osdev.org/IDT#Trap_Gate).
asleepymoon changed title from kernel: Interrupts are disabled while in system calls and enabled in exceptions to kernel: Interrupts are disabled while in system calls 2023-07-20 18:35:41 +00:00
asleepymoon commented 2024-03-29 11:47:46 +00:00
Author
Owner
Copy Link

I'm pretty sure this is intended behaviour.

I'm pretty sure this is intended behaviour.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: asleepymoon/Luna#32
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?